Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify some PHP Annotations #965

Merged
merged 1 commit into from
Aug 21, 2017
Merged

Modify some PHP Annotations #965

merged 1 commit into from
Aug 21, 2017

Conversation

imanalopher
Copy link
Contributor

@imanalopher imanalopher commented Jul 27, 2017

Q A
Branch? 1.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR

@robfrawley
Copy link
Collaborator

Please complete the PR issue template.

@imanalopher
Copy link
Contributor Author

@robfrawley, what do you mean? I don't understand you.

@robfrawley
Copy link
Collaborator

When you create a PR, the following template exists in the message body:

| Q | A
| --- | ---
| Branch? | 1.0 or 2.0 <!--choose version number-->
| Bug fix? | yes/no
| New feature? | yes/no
| BC breaks? | yes/no
| Deprecations? | yes/no
| Tests pass? | yes/no
| Fixed tickets | <!-- #-pre-fixed issue number(s), if any -->
| License | MIT
| Doc PR | <!--highly recommended for new features-->

This should be properly edited to describe the different attributes pertinent to this PR, for example:

| Q | A
| --- | ---
| Branch? | 1.0
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a

Which would render as the following in the opening comment for this PR:

Q A
Branch? 1.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@alexwilson
Copy link
Collaborator

@imanalopher -- Firstly, thanks for taking the time to contribute!

Would you mind amending the template so we can review this a bit quicker? Hate to be a stickler but even with smaller issues it's a convention to ease all our lives.

Thanks again! 🙂

@cedricziel
Copy link
Collaborator

I fixed the template for you - thx for taking the time!

@cedricziel cedricziel merged commit a4fd34a into liip:1.0 Aug 21, 2017
@robfrawley
Copy link
Collaborator

@cedricziel This has an open change request, FYI. :-)

@robfrawley robfrawley mentioned this pull request Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants