Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enqueue] Use simplified transport configuration #942

Merged
merged 1 commit into from
Jun 2, 2017
Merged

[Enqueue] Use simplified transport configuration #942

merged 1 commit into from
Jun 2, 2017

Conversation

makasim
Copy link
Collaborator

@makasim makasim commented May 25, 2017

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR this is it

@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label May 25, 2017
@robfrawley robfrawley added Type: Documentation This item pertains to documentation of this project. Level: Enhancement ✨ This item involves an enhancement to existing functionality. labels May 26, 2017
@robfrawley robfrawley added this to the 1.8.1 milestone May 26, 2017
@robfrawley
Copy link
Collaborator

@makasim Is this the new configuration syntax that resulted from the changes that came out of symfony/recipes-contrib#16?

robfrawley
robfrawley approved these changes May 30, 2017
View reviewed changes
Copy link
Collaborator

@robfrawley robfrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@makasim
Copy link
Collaborator Author

makasim commented May 31, 2017

@makasim Is this the new configuration syntax that resulted from the changes that came out of symfony/recipes-contrib#16?

yeap

@makasim makasim merged commit 73c780c into liip:1.0 Jun 2, 2017
@makasim makasim deleted the enqueue-doc branch June 2, 2017 08:59
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jun 2, 2017
@robfrawley robfrawley changed the title [enqueue] Improve doc. [Enqueue] Use simplified transport configuration Jul 13, 2017
@robfrawley robfrawley mentioned this pull request Aug 31, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robfrawley robfrawley robfrawley approved these changes

@cedricziel cedricziel cedricziel approved these changes

Assignees
No one assigned
Labels
Level: Enhancement ✨ This item involves an enhancement to existing functionality. Type: Documentation This item pertains to documentation of this project.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@makasim @robfrawley @cedricziel @lsmith77