Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Travis] Remove symfony 3.3 from build matrix "allow_failures" #940

Conversation

robfrawley
Copy link
Collaborator

@robfrawley robfrawley commented May 21, 2017

Q A
Branch? 1.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Now that Symfony 3.3 has a beta and, most recently, a release candidate, it's time we remove it from our Travis test suite allowed failures matrix. (It was actually already accidentally removed from the allowed failure by changing the environment variables in #919; this simply removes the now ignored allowed failure entry).

@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label May 21, 2017
@robfrawley robfrawley added this to the 1.8.1 milestone May 21, 2017
@cedricziel
Copy link
Collaborator

Thank you, @robfrawley !

@cedricziel cedricziel merged commit 45835f4 into liip:1.0 Jun 20, 2017
@robfrawley robfrawley changed the title Remove Symfony 3.3 from allowed failures [Travis] Remove symfony 3.3 from build matrix "allow_failures" Jul 13, 2017
@robfrawley robfrawley mentioned this pull request Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Reviewing This item is being reviewed to determine if it should be accepted.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants