Deprecate XML routing file in favor of YAML #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsmith77
added
the
State: Reviewing
robfrawley
added
RFC: Draft
Closed
rpkamp
reviewed
May 7, 2017
Resources/config/routing.yaml
Outdated
| methods: | ||
| - GET | ||
| requirements: | ||
| filter: '[A-z0-9_\-]*' |
There was a problem hiding this comment.
If a dash is at the last position of a character match you don't need to escape it, so you could use [A-z0-9_-]*.
Pierstoval
suggested changes
May 7, 2017
Resources/config/routing.xml
Outdated
| <requirement key="path">.+</requirement> | ||
| </route> | ||
| </routes> | ||
| </routes> |
Resources/config/routing.yaml
Outdated
| @@ -0,0 +1,23 @@ | |||
| --- | |||
robfrawley
force-pushed
the
feature-migrate-routing-to-yaml
branch
from
cd13162
to
f4c4af4
Compare
|
@rpkamp @Pierstoval Comments addressed; thanks! |
Pierstoval
suggested changes
May 7, 2017
UPGRADE.md
Outdated
| @@ -1,5 +1,10 @@ | |||
| # Upgrade | |||
|
|
|||
| ## 1.7.5 | |||
There was a problem hiding this comment.
In terms of semver, deprecations should come in minor versions, not patch versions, is it a problem if you need to push these changes to 1.8.0 instead of 1.7.5?
There was a problem hiding this comment.
Nope, though it looks like we've broken this rule a bunch in prior patch releases. :-(
There was a problem hiding this comment.
Ok, well if it's a bugfix it's totally fine 😆
robfrawley
force-pushed
the
feature-migrate-routing-to-yaml
branch
from
f4c4af4
to
81f9856
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecating the XML routing file in favor of YAML enables providing a more user-friendly format for the Symfony Flex recipe, and YAML is, IMHO, generally more user-friendly for this bundle as a stand-alone package, as well.
The old
routing.xmlfile remains, to provide backward compatibility for users, but instead of containing routes it simply imports the newrouting.yamlfile. The XML file is deprecation in theUPGRADE.mdfile and can be safely removed from the2.xbranch entirely.The installation RST documentation has been updated to use the YAML routing varient, as well.