Updating twig call to utilise asset(), to match README.md (closes #830) #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsmith77
added
the
State: Reviewing
|
Hmm... why is Travis trying to clone branch |
|
Not sure, I reckon it's cached a copy of the repo with my initial incorrect branch and it's trying to somehow resolve that commit to that branch - All the more reason to avoid pushing to branches on here! |
lsmith77
removed
the
State: Reviewing
|
@antoligy Cherry picked your commit for 2.x branch: https://github.com/liip/LiipImagineBundle/commits/2.0 |
|
Sounds good- Is it worth establishing a standard for how we push 1.0 changes to 2.0? I am happy to cherry pick but obviously this becomes more of a problem with more commits. |
|
I know... and I agree. Suggestions for a standard? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #834, only on my fork and with without me breaking the test suite.