Require components that no longer ship with Symfony FrameworkBundle 3.2 #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm pretty happy with this, it addresses my concerns with #832 pretty neatly! |
|
👍 |
1 similar comment
|
👍 |
|
Merged and rebased into 2.0, thanks for the contribution @rpkamp! @robfrawley, I performed an interactive rebase against 1.0, lemme know if there are any issues with the way I've done it so we can course-correct! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 3.2 FrameworkBundle no longer requires symfony/asset, symfony/templating and symfony/translation anymore, causing several tests to fail. By requiring them explicitly the tests no longer fail.
Additionaly, this PR makes symfony 3.2 required for Travis, since symfony 3.2 is final now, and also adds PHP 7.1 to the test matrix, since that is final now as well.
This PR is an alternative to #831, which marks the tests with missing dependencies as skipped.