Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RST indentation error in AWS S3 cache resolver documentation #809

Merged
merged 2 commits into from
Oct 1, 2016
Merged

Fix RST indentation error in AWS S3 cache resolver documentation #809

merged 2 commits into from
Oct 1, 2016

Conversation

GeoffreyHervet
Copy link
Contributor

No description provided.

@robfrawley
Copy link
Collaborator

@GeoffreyHervet I don't follow what you're trying to fix... you added an extra tab? Can you provide some clarity. Thanks!

@GeoffreyHervet
Copy link
Contributor Author

On the Symfony documentation the code yml section is broken :( It should fix it. It's also broken with on github.

Let me know if I'm wrong,
(my preview with extra tabs)

Best,
G

@robfrawley robfrawley added Type: Documentation This item pertains to documentation of this project. State: Confirmed This item has been confirmed by maintainers as legitimate. labels Oct 1, 2016
@robfrawley robfrawley added this to the v1.7.0 milestone Oct 1, 2016
@robfrawley robfrawley changed the title Fix bad md format aws_s3.rst Fix invalid RST format in aws_s3.rst Oct 1, 2016
@robfrawley
Copy link
Collaborator

robfrawley commented Oct 1, 2016

@GeoffreyHervet I've added a wiki article on building the RST documentation, which should assist those such as yourself testing changes/fixes to the documentation moving forward: https://github.com/liip/LiipImagineBundle/wiki/Building-RST-Documentation

Thanks for this PR!

@robfrawley robfrawley changed the title Fix invalid RST format in aws_s3.rst Fix RST indentation error in AWS S3 cache resolver documentation Oct 1, 2016
@robfrawley robfrawley merged commit b33539e into liip:master Oct 1, 2016
@lsmith77 lsmith77 removed the State: Confirmed This item has been confirmed by maintainers as legitimate. label Oct 1, 2016
@robfrawley
Copy link
Collaborator

robfrawley commented Oct 1, 2016

@lsmith77 Ping (RST documentation rebuild needs to be triggered)

@GeoffreyHervet
Copy link
Contributor Author

@robfrawley Thank the link & the merge :)

@lsmith77
Copy link
Contributor

lsmith77 commented Oct 3, 2016

@javiereguiluz is this done automatically at regular time intervals or is this a manual process?

@javiereguiluz
Copy link
Contributor

@lsmith77 it's automatic. The published page seems to have applied the changes of this PR: http://symfony.com/doc/current/bundles/LiipImagineBundle/cache-resolver/aws_s3.html

However, this PR may have used too much indentation for the last level (key, secret, etc.)

indentation

@robfrawley
Copy link
Collaborator

@javiereguiluz Thanks for the info; we weren't sure if it was automatically handled. Appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation This item pertains to documentation of this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants