-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LICENSE.md #790
Add LICENSE.md #790
Conversation
Should this also reference the original Avalanche bundle? |
Good question... I don't have a firm answer there. The purpose of this pull request is to move the license file (currently burried under Resource/meta/LICENSE), update dates, move to a markdown varient, and add a link to the GitHub contributors page. But it all started because it annoyed me that it took 10 minutes of hunting around to find this bundle's license initially. ;-) That being said, even though the current license doesn't include a reference to Avalanche, that could have very likely been an oversight at the time. I'm more than happy to add a reference to Avalanche. Thoughts? |
e9e48df
to
ad7bb95
Compare
After a quick trip down Git history, I can confirm this code base absolutely shares commit ancestors with Avalanche from early to late 2011, including a few instances of files that still existing verbatim from that period in history. Therefore, I've gone ahead and added the original copyright author that appears in the Avalanche codebase from the shared 2011 commits, providing us with the following updated license file. |
ad7bb95
to
d8a9d38
Compare
Huge thanks for looking into that! |
the license file is in the current location due to Symfony standards .. then again they might have evolved since then .. just checked .. yeah it seems like the new standard is to put it into the root as "LICENSE": |
@lsmith77 Do you want to drop the markdown from the LICENSE? I'll update this PR if that is desired. |
checking via twitter https://twitter.com/lsmith/status/774138202567258112 |
…LICENSE. Detailed changes: - Created a simple, markdown-styled version of the MIT license. - Added Liip website to license (ttps://www.liip.ch/) - Added GitHub Contributors to license copyright - Contributors link: https://github.com/liip/LiipImagineBundle/graphs/contributors Previous, squashed commits include: 1. Add new root-level LICENSE.md to project 2. Remove Resources/meta/LICESNE (old location of license) added avalance original copyright notice updated avalanche link updated license to remove markdown moved license to non-md extension
d8a9d38
to
e05792f
Compare
@lsmith77 Looks like Twitter has spoken. ;-) Updated. |
Add the MIT License to the project root directory with a copyright line reflective of those who have contributed.