Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore invalid exif orientations #751

Merged
merged 1 commit into from
Jul 15, 2016
Merged

Ignore invalid exif orientations #751

merged 1 commit into from
Jul 15, 2016

Conversation

lstrojny
Copy link
Contributor

@lstrojny lstrojny commented Jul 4, 2016

While exif orientation values should theoretically only be between 1 and 8, the reality is different. We’ve seen all kinds of values from 0 to 256 to 65535.

@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jul 5, 2016
@lsmith77
Copy link
Contributor

@lstrojny can you look into the CS issues?

furthermore .. do you have any link that would support the claim that other values are possible "in the wild"?

@lstrojny
Copy link
Contributor Author

@lsmith77 the CS issues aren’t introduced with this PR but have been there before. Should we fix them with this PR?
On sources: quick googling revealed this issue by the Wikimedia project (https://phabricator.wikimedia.org/T34868) which isn't about out of range exif tags but duplicate exif tags.

@lsmith77
Copy link
Contributor

regarding the CS issues: doh .. fixed via #757

as for the validation/exception .. maybe the sensible thing to do is make it a config option?

@lstrojny
Copy link
Contributor Author

@lsmith77 I am against making it a configuration option as I don't see the use case for it. Why would anyone want an image to not be rendered at all instead of the current behavior which strips the (invalid) exif information and presents the image as-is.

@lsmith77
Copy link
Contributor

not sure .. but I assume if you use the auto rotate filter, you want to know the image is rotated accordingly and if an image cannot be rotated then you have a problem. then again I guess this should be validated before it even gets to this Bundle.

@lsmith77 lsmith77 merged commit 53f2307 into liip:master Jul 15, 2016
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jul 15, 2016
@lstrojny lstrojny deleted the bugfix/exif-invalid-values branch July 15, 2016 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants