Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

background filter: allow image positioning #721

Merged
merged 1 commit into from
Jul 12, 2016
Merged

background filter: allow image positioning #721

merged 1 commit into from
Jul 12, 2016

Conversation

uvoelkel
Copy link
Contributor

allow positioning of the image on the background. uses the same position options as the watermark filter.

@uvoelkel
background filter: allow image positioning
e9160b1 
allow positioning of the image on the background.
uses the same position options as the watermark filter.
@uvoelkel
Copy link
Contributor Author

Scrutinizer - rightfully - complains about code duplication.
Should I move the position calculation into its own class? If so, where to put it and what to name it.

@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jun 19, 2016
@lsmith77 lsmith77 merged commit 4bf0e7d into liip:master Jul 12, 2016
@lsmith77
Copy link
Contributor

thx!

@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jul 12, 2016
@uvoelkel uvoelkel deleted the background-filter-position branch March 16, 2017 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uvoelkel @lsmith77