-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebased commands document patch, see #533 #680
Conversation
The documentation format is not github's markdown. See how other docs are formatted. ping @javiereguiluz |
@helios-ag I'm afraid @makasim is right. The documentation of this bundle must follow Symfony practices because we display it on symfony.com/doc . If you are not familiar with the new format, please review these two quick articles: http://symfony.com/doc/current/contributing/documentation/format.html and http://symfony.com/doc/current/contributing/documentation/standards.html |
file updated, @javiereguiluz |
@helios-ag very nice! Thanks. Minor comment: maybe this line is too long and it could be wrapped at 80 characters: https://github.com/liip/LiipImagineBundle/pull/680/files#diff-887f7928659ec2ad4990a59f5c3c0f82R64 |
@javiereguiluz comments reviewed, changes applied. |
@javiereguiluz Could you please review. I need your confirm to merge this |
.. code-block:: bash | ||
|
||
$ php app/console liip:imagine:cache:remove path1 path2 --filters=thumb1 --filters=thumb2 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unneeded extra blank line.
@makasim done! Everything is fine except some minor issues with blank lines. |
@javiereguiluz thank you very much. |
@makasim done |
rebased commands document patch, see #533
@helios-ag Thanks |
Rebased patch #533