Fix deprecated twig filter syntax #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is not available since 1.0, right? So we have to raised a minimum twig version, Which one should it be? |
| @@ -27,7 +27,7 @@ public function __construct(CacheManager $cacheManager) | |||
| public function getFilters() | |||
| { | |||
| return array( | |||
| 'imagine_filter' => new \Twig_Filter_Method($this, 'filter'), | |||
| new \Twig_SimpleFunction('imagine_filter', array($this, 'filter')), | |||
There was a problem hiding this comment.
this is wrong. Should be \Twig_SimpleFilter instead
|
@makasim it is available since |
|
@Koc thanks, @Rattler3 Could you update a twig section in composer json, saying that |
|
@makasim I left twig requiring less than version 2 as this has not yet been released and could require more amends. |
|
@Rattler3 I meant the description of suggest section https://github.com/liip/LiipImagineBundle/pull/631/files#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780L45 |
|
@makasim I have added a note about the version needing to be greater than 1.12 |
makasim
added a commit
that referenced
this pull request
Aug 27, 2015
Fix deprecated twig filter syntax
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of Twig 1.21, deprecated calls in twig are being logged. Noticed this one.