Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use identity instead equality #619

Merged
merged 1 commit into from
Oct 27, 2015
Merged

Use identity instead equality #619

merged 1 commit into from
Oct 27, 2015

Conversation

piotrantosik
Copy link
Contributor

No description provided.

@makasim
Copy link
Collaborator

makasim commented Jul 19, 2015

why? array_key_exists always returns boolean

@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jul 21, 2015
@piotrantosik
Copy link
Contributor Author

I know but is more readable for psr.
Basically this should be.

if (!array_key_exists($filter, $this->filters)) {
    throw new NonExistingFilterException(sprintf('Could not find configuration  for a filter: %s', $filter));
}

Is acceptable?

@trsteel88
Copy link
Contributor

I prefer false ===

lsmith77 added a commit that referenced this pull request Oct 27, 2015
Use identity instead equality
@lsmith77 lsmith77 merged commit a3834d6 into liip:master Oct 27, 2015
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants