Allow configuring putObject options when saving to S3 #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -314,6 +326,9 @@ public function testProcessCorrectlyOptionsOnAddConfiguration() | |||
| $this->assertArrayHasKey('url_options', $config); | |||
| $this->assertEquals($expectedUrlOptions, $config['url_options']); | |||
|
|
|||
| $this->assertArrayHasKey('url_options', $config); | |||
There was a problem hiding this comment.
i think you should check for object_options key here ?
There was a problem hiding this comment.
Good catch, fixed.
| @@ -93,6 +94,10 @@ public function addConfiguration(ArrayNodeDefinition $builder) | |||
| ->useAttributeAsKey('key') | |||
| ->prototype('scalar')->end() | |||
| ->end() | |||
| ->arrayNode('object_options') | |||
There was a problem hiding this comment.
what about put_options name. It would be better to rename url_options to get_options but we can due BC promise.
There was a problem hiding this comment.
Ok, I'll rename it to put_options. I kinda disliked object_options initially.
We can probably rename url_options to get_options as well, update the docs and just provide B/C so that url_options are just converted to get_options. It should be a separate PR though.
There was a problem hiding this comment.
just provide B/C so that url_options are just converted to get_options
good idea.
|
merged as part of #535 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this to be able to control
CacheControlheaders returned from S3 (it makes a lot of sense when you serve images from S3), but it can be used for setting other options as well (e.g.ContentDisposition)