Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for last version of symfony #50

Merged
merged 1 commit into from
Feb 20, 2012
Merged

Fix for last version of symfony #50

merged 1 commit into from
Feb 20, 2012

Conversation

benji07
Copy link
Contributor

@benji07 benji07 commented Feb 16, 2012

when i update symfony this bundle doesn't work anymore.

[Symfony\Component\Config\Definition\Exception\InvalidDefinitionException]

Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition::useAttributeAsKey() is not applicable to concrete nodes.

@stof
Copy link
Contributor

stof commented Feb 16, 2012

Please wait a bit before merging this. The change in Symfony will probably be reverted as @schmittjoh said it is wrong

@lsmith77
Copy link
Contributor

@stof: is this issue tracked in a ticket or a PR?

@stof
Copy link
Contributor

stof commented Feb 19, 2012

Looking at it again, using this method is indeed wrong here. Symfony 2.0 simply ignored it but removing it is indeed a good idea so you can merge it.
@schmittjoh said it is wrong in the PR sent by @vicb but he has not explained why when asking for details

@schmittjoh
Copy link

What is wrong is the Assetic PR as it is not behaviorally equivalent to the previous version. If the changes were necessitated by victor's PR on symfony (which I haven't had time to review yet), then there is something wrong as well.

lsmith77 added a commit that referenced this pull request Feb 20, 2012
Fix for last version of symfony
@lsmith77 lsmith77 merged commit 365d63c into liip:master Feb 20, 2012
@stof
Copy link
Contributor

stof commented Feb 20, 2012

@schmittjoh the PR done by @vicb on symfony makes the validation stricter instead of silently ignoring methods that make no sense for prototyped nodes (similarly to some other methods that were already validated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants