fix auto rotate #476
Merged
fix auto rotate #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| return null; | ||
| } else { |
There was a problem hiding this comment.
not related to this PR .. but I guess the else isn't needed if we always return in the if
There was a problem hiding this comment.
The if is for old version of imagine bundle. but no idea if the else part is working as it should.
|
changed the assignment to be before the condition |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced 2 problems getting the images rotated correctly when directly uploaded by my iphone (reported from other phones like android too).
imagine.xmlon theliip_imaginealias did not work. When compiling the DI there were no added method call.ifd0.Orientatioand not as hardcoded underexif.OrientationWith the provided solution my directly uploaded pictures get autorotated correctly.