[router] remove custom route loader. #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makasim
added a commit
that referenced
this pull request
May 5, 2014
[router] remove custom route loader.
|
What benefit? Code simplification/minimization? |
@Koc Yes. It may also give some impr in performance. Before we had a route for each filter, Say you have 20 filters so you have 20 routes. Sounds good? |
|
Yes. 👍 . |
franmomu
added a commit
to franmomu/LiipImagineBundle
that referenced
this pull request
Sep 1, 2019
The rest of the code was remove in liip#425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some BC breaks between 1.0.0-alpha5 and 1.0.0-alpha6. More details here.
@havvg please review