added possibility to use imagine new metadata api #413
Conversation
| @@ -17,7 +17,7 @@ | |||
| }, | |||
| "require": { | |||
| "php": ">=5.3.2", | |||
| "imagine/Imagine": "0.5.*", | |||
| "imagine/Imagine": "~0.5", | |||
There was a problem hiding this comment.
@digitalkaoz are you sure the feature available from 0.5.0 version. I'd say we have to add ~0.5.x restriction, something like that
There was a problem hiding this comment.
the feature is only available in 0.6 but i wanted to keep bc (and dont force people to upgrade imagine (0.6. is still dev))
There was a problem hiding this comment.
sorry, I have written a comment and just after that saw that bc layer. Looks good to me.
There was a problem hiding this comment.
dont know other filter implications if upgrading to 0.6 @see https://github.com/avalanche123/Imagine/blob/develop/CHANGELOG.md#060-2014-xx-xx
|
@digitalkaoz could you rebase? |
|
done |
|
@digitalkaoz still is not mergeable. are you sure you rebase the latest master? |
|
ok, now it should...lets wait for travis |
| @@ -98,9 +99,13 @@ | |||
| <argument type="service" id="liip_imagine.cache.signer" /> | |||
| </service> | |||
|
|
|||
| <service id="liip_imagine.meta_data.reader" class="%liip_imagine.meta_data.reader.class%" /> | |||
added possibility to use imagine new metadata api
|
@digitalkaoz thanks |
removed the hardcoded version pinning on imagine 0.5
using the new metadata-api in autorotatefilter.
should be bc.