Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move data loaders to binary folder #382

Merged
merged 4 commits into from
Apr 4, 2014

Conversation

serdyuka
Copy link
Contributor

@serdyuka serdyuka commented Apr 4, 2014

No description provided.

<parameter key="liip_imagine.data.loader.filesystem.class">Liip\ImagineBundle\Imagine\Data\Loader\FileSystemLoader</parameter>
<parameter key="liip_imagine.data.loader.stream.class">Liip\ImagineBundle\Imagine\Data\Loader\StreamLoader</parameter>
<parameter key="liip_imagine.data.loader.filesystem.class">Liip\ImagineBundle\Binary\Loader\FileSystemLoader</parameter>
<parameter key="liip_imagine.data.loader.stream.class">Liip\ImagineBundle\Binary\Loader\StreamLoader</parameter>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

liip_imagine.data.loader.xxx.class -> liip_imagine.binary.loader.xxx.class

@makasim
Copy link
Collaborator

makasim commented Apr 4, 2014

@serdyuka Please update UPGRADE.md file to and remove images generated by tests

@serdyuka
Copy link
Contributor Author

serdyuka commented Apr 4, 2014

@makasim review please

makasim added a commit that referenced this pull request Apr 4, 2014
@makasim makasim merged commit bab39ad into liip:master Apr 4, 2014
@makasim
Copy link
Collaborator

makasim commented Apr 4, 2014

Thanks @serdyuka

@makasim makasim deleted the move-data-loaders branch April 4, 2014 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants