[1.0][resolver] do not expose targetPath

[makasim]

next refactoring step after #281

fixes #162

[LouTerrailloune]

1. Regarding getBrowserPath, may be it should return null when no specific url is need (or when cache has not been generated), the cache manager will then return the target url (which point to the imagine controller).
2. Regarding the injection of the cacheManger into the resolvers, is it really needed ? (seems to be used only by WebPathResolver to get the web root and by other resolvers to get the target url (which will not be needed anymore if getBrowserPath return null (first point above)).

[makasim]

I've setuped a sandbox for this bundle. I am testing web path and aws s3. It gives me more confidence in the work I am doing.

Just want to let you know.

@LouTerrailloune I would respond you asap. I still have to review the code and check your suggestions.

[makasim]

@havvg this is ready for review.

@LouTerrailloune thanks for your reply I found Resolver::getBrowserPath method completely useless. I am trying to get rid of it and I would open another PR once it is ready.

[havvg]

There is no need for this variable.

[havvg]

The CacheManager::remove method should rename its parameter to path, too.

[havvg]

The context key should be renamed to objectPath, too.

[makasim]

@havvg I believe I address all your comments. What about tests? Are you succeeded to run them locally?

To run tests you have to run composer with --dev and the phpunit. nothing special.

[makasim]

@havvg I did not squash commits because you may want to review them separately. Will do a rebase and squash once you say it is good to be merged

[havvg]

Thanks so far, I will take another look. The tests are running now locally.

[havvg]

PR out, good to rebase/squash :)

[makasim]

@havvg rebased&squashed. I squashed your commits as a separate commit.

[makasim]

@havvg ping

[havvg]

Thank you!