add filter to perform a relative resize, thus keeping the aspect ratio, and not exceeding a max width and a max height #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 18, 2013 08:46
…o, and not exceeding a max width and a max height
|
Hm.. I'm not into image processing as it, is "two-way resize" a common name reflecting the behavior? |
| } | ||
|
|
||
| $filter = new TwoWayRelativeResize($newHeight, $newWidth); | ||
| return $filter->apply($image); |
There was a problem hiding this comment.
Missing empty line before return.
|
This is a duplicate filter isn't it? The thumbnail filter can already do this with mode "inset" thumbnail: { size: [270, 185], mode: inset } |
|
@trsteel88 you seem to be correct... I tested that option yesterday, but then it didn't seem to do that. Tried again just now, and it indeed works. Guess I got cache-raped... So nevermind, I'll close this one |
|
if this was unclear .. maybe the docs can be improved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.