fix broken tests on windows #179
Conversation
| @@ -14,7 +14,13 @@ class AbstractFilesystemResolverTest extends AbstractTest | |||
| public function testStoreCyrillicFilename() | |||
| { | |||
| $image = $this->fixturesDir.'/assets/АГГЗ.jpeg'; | |||
| $data = file_get_contents($image); | |||
|
|
|||
| $data = @file_get_contents($image); | |||
There was a problem hiding this comment.
Why is this error suppressed?
|
With regards to the first 3 comments.. These relate to the fact the file_get_contents does not work on Windows with UTF-8 file names.. I attempted to find a way around it without any luck. So, either the test could be skipped on windows .. because it is known that it's not supported. I didn't want to leave it as a failure because it could be misleading that it's a "failure" when it's actually expected behavior on Windows. Let me know which you prefer. |
|
Thanks, then I would prefer to have a skip with a clear message about it. I'm not familiar with Windows ;) So I would say the same like https://github.com/kevarch/LiipImagineBundle/blob/7246305db33eb125222cc20cd51f5ce76ba46148/Tests/Imagine/Cache/Resolver/AbstractFilesystemResolverTest.php#L39-L41 should be put here https://github.com/kevarch/LiipImagineBundle/blob/7246305db33eb125222cc20cd51f5ce76ba46148/Tests/Imagine/Cache/Resolver/AbstractFilesystemResolverTest.php#L14-L22 instead of the error suppression and stuff. |
|
Thank you! |
This PR may seem unimportant but the test suite should pass on windows.