Added check for the existence of extension info #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, could you please add a test case for this? |
…dability. Added test for missing extension information
|
Added test. Nothing sophisticated, just one that would have failed before this patch. |
havvg
added a commit
that referenced
this pull request
Feb 13, 2013
Added check for the existence of extension info
|
Those tests are the best, if the fail without and pass with the patch provided :-) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a notice issue occurring when passing a filename with no extension:
Notice: Undefined index: extension in vendor/liip/imagine-bundle/Liip/ImagineBundle/Imagine/Data/Loader/FileSystemLoader.php line 69