Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHPUnit 7.5 and test clean up #1243

Merged
merged 6 commits into from
Nov 27, 2019
Merged

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Nov 22, 2019

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no?
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

I updated some tests, removed deprecations, PHPDoc, etc.

EDIT:
I added the last commit adding types... not sure about BC

@michellesanver
Copy link
Contributor

Quite a beast!! Awesome. Thanks a lot!!! <3

@michellesanver michellesanver merged commit bbac1a6 into liip:master Nov 27, 2019
@franmomu franmomu deleted the clean_up_tests branch November 27, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants