Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support for php 7.2, 7.3 #628

Merged
merged 2 commits into from
May 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,21 @@ jobs:
strategy:
fail-fast: false
matrix:
php-version: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2']
php-version: ['7.4', '8.0', '8.1', '8.2']
composer-flags: ['']
symfony-version: ['^5.4']
include:
- php-version: 7.2
- php-version: 7.4
symfony-version: "^4.4"
composer-flags: "--prefer-lowest"
- php-version: 7.2
symfony-version: "^4.4"
- php-version: 7.3
symfony-version: "^4.4"
- php-version: 7.4
symfony-version: "^4.4"
- php-version: 8.0
symfony-version: "^4.4"
- php-version: 8.1
symfony-version: "^6.0"
symfony-version: "^6.2"
- php-version: 8.2
symfony-version: "^6.2"

steps:
- name: Checkout
Expand All @@ -39,7 +37,7 @@ jobs:

- name: Get composer cache directory
id: composercache
run: echo "::set-output name=dir::$(composer config cache-files-dir)"
run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT

- name: Cache composer dependencies
uses: actions/cache@v3
Expand Down
8 changes: 6 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,15 @@

## 5.0 (to be released)

Removed features deprecated in [4.6](#4.6)
Removed features deprecated in [4.6](#46)

## 4.10

Drop support for php 7.2, 7.3
Chris53897 marked this conversation as resolved.
Show resolved Hide resolved

## 4.7

Deprecations from [4.6](#4.6) will now trigger an `E_USER_DEPRECATED` deprecation
Deprecations from [4.6](#46) will now trigger an `E_USER_DEPRECATED` deprecation

## 4.6

Expand Down
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
}
],
"require": {
"php": "^7.2 || ^8.0",
"phpunit/phpunit": "^7.5.0 || ^8.0 || ^9.0 || ^10.0",
"php": "^7.4 || ^8.0",
"phpunit/phpunit": "^9.6 || ^10.0",
"symfony/browser-kit": "^4.4 || ^5.1 || ^6.0",
"symfony/framework-bundle": "^4.4 || ^5.1 || ^6.0"
},
Expand Down
2 changes: 1 addition & 1 deletion tests/Command/CommandTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public function testRunCommandWithoutOptionsAndNotReuseKernel(bool $useEnv): voi
$this->assertStringContainsString('Verbosity level: NORMAL', $this->commandTester->getDisplay());
}

public function useEnvProvider(): array
public static function useEnvProvider(): array
{
return [
[true],
Expand Down
2 changes: 1 addition & 1 deletion tests/DependencyInjection/ConfigurationConfigTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ protected static function getKernelClass(): string
/**
* Override values to be tested.
*/
public function parametersProvider(): array
public static function parametersProvider(): array
{
return [
['command_verbosity', 'very_verbose'],
Expand Down
6 changes: 3 additions & 3 deletions tests/DependencyInjection/ConfigurationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@
namespace Liip\Acme\Tests\DependencyInjection;

use Liip\FunctionalTestBundle\Test\WebTestCase;
use Symfony\Component\DependencyInjection\ContainerInterface;

/**
* Test default configuration.
*/
class ConfigurationTest extends WebTestCase
{
/** @var \Symfony\Component\DependencyInjection\ContainerInterface */
private $clientContainer = null;
private ?ContainerInterface $clientContainer = null;

protected function setUp(): void
{
Expand Down Expand Up @@ -52,7 +52,7 @@ public function testParameter($node, $value): void
);
}

public function parametersProvider(): array
public static function parametersProvider(): array
{
return [
['command_verbosity', 'normal'],
Expand Down