Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database cache from 2.x #402

Merged
merged 1 commit into from
May 7, 2018
Merged

database cache from 2.x #402

merged 1 commit into from
May 7, 2018

Conversation

alekseytupichenkov
Copy link
Contributor

required #398

alexislefebvre
alexislefebvre reviewed Mar 25, 2018
View reviewed changes
src/Test/WebTestCase.php Outdated
/**
* @var array
*/
private static $cachedMetadatas = [];
Copy link
Collaborator

@alexislefebvre alexislefebvre Mar 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this change is here, since the code was removed in your previous PR: https://github.com/liip/LiipFunctionalTestBundle/pull/398/files#diff-3216cb8554ab63f3b7b8531ebcee5156

Maybe rebasing your PR on the 2.x could fix this issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm.. I'll check it today

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@alekseytupichenkov alekseytupichenkov force-pushed the db_cache_from_2.x branch 2 times, most recently from 4164c0b to f556d11 Compare March 28, 2018 06:02
@alekseytupichenkov alekseytupichenkov changed the base branch from 2.x to master March 28, 2018 06:03
@alekseytupichenkov alekseytupichenkov changed the base branch from master to 2.x March 28, 2018 06:03
maximgubar
maximgubar approved these changes May 7, 2018
View reviewed changes
src/Services/DatabaseBackup/MongodbDatabaseBackup.php
/*
* This file is part of the Liip/FunctionalTestBundle
*
* (c) Lukas Kahwe Smith <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the code actually belongs to Lukas ?

@maximgubar maximgubar merged commit 6e8116f into liip:2.x May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexislefebvre alexislefebvre alexislefebvre left review comments

@maximgubar maximgubar maximgubar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alekseytupichenkov @alexislefebvre @maximgubar