Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move files to src and tests directory #324

Closed
wants to merge 1 commit into from

Conversation

ruudk
Copy link

@ruudk ruudk commented Jun 1, 2017

See #323

Moving all the sources to src and tests to tests.

This way, the tests won't be distributed when people use this library.

Tests are failing because of HHVM #326

@ruudk ruudk force-pushed the split-src-tests branch 3 times, most recently from ca67f0c to 9044bd5 Compare June 1, 2017 16:38
@ruudk ruudk force-pushed the split-src-tests branch from 9044bd5 to 2c2dad3 Compare June 1, 2017 16:53
@alexislefebvre
Copy link
Collaborator

Is it a feature from Composer to not share files in the tests directory?

@ruudk
Copy link
Author

ruudk commented Jun 15, 2017

Yep, see this in composer.json

 "autoload": {
        "psr-4": {
            "Liip\\FunctionalTestBundle\\": "src/"
        }
    },
    "autoload-dev": {
        "psr-4": {
            "Liip\\FunctionalTestBundle\\Tests\\": "tests/"
        }
    },

@ruudk
Copy link
Author

ruudk commented Jun 15, 2017

It makes sure that when I require this is a normal dependency (non dev) it will only pull src

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants