Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loadFixtures() without arguments #310

Merged
merged 3 commits into from
Mar 20, 2017
Merged

Allow loadFixtures() without arguments #310

merged 3 commits into from
Mar 20, 2017

Conversation

Grafikart
Copy link
Contributor

No description provided.

@alexislefebvre
Copy link
Collaborator

$this->loadFixtures(array()); already work for loading empty fixtures. With you PR we can call $this->loadFixtures();? I'm asking this because the title of this PR is a little bit confusing. :)

Can you please add a corresponding test? You just have to create a function similar to testLoadEmptyFixtures(), but without array(). Thanks

@Grafikart
Copy link
Contributor Author

Yeah sorry the title is indeed misleading. I did the PR using github directly, I'll create a branch to add the test later this afternoon

@Grafikart Grafikart changed the title Allow loading empty fixtures Allow loadFixtures() without arguments Mar 20, 2017
@Grafikart
Copy link
Contributor Author

Do I create a new test or change the current one ?

@alexislefebvre
Copy link
Collaborator

Please add a new test (a new function), so we'll check $this->loadFixtures(array()); and $this->loadFixtures(); both work.

@Grafikart
Copy link
Contributor Author

I just added the test

@alexislefebvre alexislefebvre merged commit be78ee4 into liip:master Mar 20, 2017
@alexislefebvre
Copy link
Collaborator

Thanks!

@alexislefebvre
Copy link
Collaborator

alexislefebvre commented Mar 23, 2017

Hi @Grafikart, it looks like we will have to revert this change because it breaks some tests environment: see #311. I don't see any other solution.

alexislefebvre added a commit that referenced this pull request Mar 23, 2017
@alexislefebvre alexislefebvre added this to the 2.0 milestone Dec 7, 2017
alexislefebvre pushed a commit to alexislefebvre/LiipFunctionalTestBundle that referenced this pull request Jan 10, 2018
* Allow loading empty fixtures
* Added a test for loadFixtures without parameters
alexislefebvre pushed a commit to alexislefebvre/LiipFunctionalTestBundle that referenced this pull request Jan 11, 2018
* Allow loading empty fixtures
* Added a test for loadFixtures without parameters
alexislefebvre added a commit that referenced this pull request Jan 11, 2018
…t-arguments-310

Allow loadFixtures() without arguments (#310)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants