-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Dockerfile #70
add Dockerfile #70
Conversation
Thanks for this! I have a docker hub account although my usage of docker is so minimal it didn't even occur to me to release there as well. Also, the tests are failing since prs cannot access secure env vars which are used for the online tests. I thoguht I figured out that issue but obviously it doesn't work. I may use you as a test subject to test the workaround since I can't do it myself. |
ok, looked into it. Please push the changes you mentioned in the comment to build from source and ill setup the automated builds. Also i added some debugging to the logs to try and figure out what i did wrong with skipping these online tests from prs |
Thanks for the quick response. I've updated the Happy to help test the Travis changes. |
i pushed a fix to the test issue, please sync |
Codecov Report
@@ Coverage Diff @@
## develop #70 +/- ##
============================================
- Coverage 88% 74.03% -13.98%
============================================
Files 39 39
Lines 1317 1317
============================================
- Hits 1159 975 -184
- Misses 158 342 +184
Continue to review full report at Codecov.
|
@liiight the travis tests look good. I'm not really sure why codecov is complaining about lower coverage though. Would you like me to squash the commits? |
codecov complains because now a lot of the test are skipped which appears to drop the coverage, don't worry about it. Also, I squashed on merge so no need for any more action on you end. Thanks for this! I'll update here as well when i setup the automated docker build, |
done: https://hub.docker.com/r/liiight/notifiers/ i'm pushing 0.6.2 so it'll populate master branch |
Thanks! fyi - Looks like the auto formatted readme on https://hub.docker.com/r/liiight/notifiers/ isn't rendering the badges. I'm not very familiar with RST, but the following Markdown will work correctly on Dockerhub.
|
The problem with that is that pypi requires rst... |
Based on docker/hub-feedback#621 it looks like Docker isn't in any hurry to add rst support 😞. If you wanted to get it fixed in the short term you could manually modify the full description on https://hub.docker.com/r/liiight/notifiers/. However, it isn't a big deal, so eventually having a markdown readme would be great. |
changes
I've added a fairly basic Dockerfile that is based on
python:alpine3.6
usage
docker build .
docker run <image> <notifiers command args>
Ideally the image would be uploaded to docker hub via a automated build, but travis ci would also work.
I don't see the workflow to publish notifiers to pypi, so if it makes more sense to build from source I'm happy to update the PR with:
Thanks!
Jordan