Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repro possible race condition #424

Closed
wants to merge 1 commit into from
Closed

Conversation

pellared
Copy link

@pellared pellared commented Apr 5, 2023

@jmacd
Copy link
Contributor

jmacd commented Apr 5, 2023

This test is racing with itself, right?

@pellared
Copy link
Author

pellared commented Apr 5, 2023

@jmacd This just what I meant by a possible race condition. I do not know if it is an issue. I just wanted to demonstrate what I meant 😉 As far as I understand open-telemetry/opentelemetry-go#3947 such race would not be present as attribute.Set is immutable.

EDITED

@pellared
Copy link
Author

pellared commented Apr 5, 2023

However, I agree that it is making a race condition "on your own will".

@pellared pellared closed this Apr 5, 2023
@pellared pellared deleted the patch-1 branch April 5, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants