Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing tests for global async instrument registration and unwrapping #794

Open
jmacd opened this issue Oct 15, 2024 · 0 comments
Open

Missing tests for global async instrument registration and unwrapping #794

jmacd opened this issue Oct 15, 2024 · 0 comments

Comments

@jmacd
Copy link
Contributor

jmacd commented Oct 15, 2024

Describe the bug
As discussed in #793,
testing is incomplete for global asynchronous instrument registration. The SDK will log errors but no test actually fails when registration is broken.

To Reproduce
Remove the calls to Unwrap(metric.Observer) metric.Observer and notice that no tests break while new log messages appear.

Expected behavior
Should be tested.
@jmacd jmacd mentioned this issue Oct 15, 2024
Merged
jmacd added a commit that referenced this issue Oct 15, 2024
@jmacd
Update OTel-Go, OTel-Collector, and OTel-Arrow dependencies (#793)
6e52c14 
**Description:** Updates to OTel-Go 1.31 require minor LS Metric SDK
fixes (see Unwrap()), discussed and fixed in the upstream PR
open-telemetry/opentelemetry-go#5881. The
Unwrap() calls here are to work around the problem until fully fixed
upstream.

**Link to tracking Issue:**
open-telemetry/opentelemetry-go#5827 explains
how we got here.

Part of #794.

**Testing:** Incomplete. Existing tests were logging messages about
foreign instruments in the asynchronous call path, but nothing failed as
a result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmacd