Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of span context propagation #118

Merged
merged 33 commits into from
Sep 6, 2018
Merged

Improve performance of span context propagation #118

merged 33 commits into from
Sep 6, 2018

Conversation

rnburn
Copy link
Contributor

@rnburn rnburn commented Sep 5, 2018 •
edited
Loading

Replaces the stringstream-based hex-integer conversion code with faster alternatives. Here are benchmarks from before and after showing significant performance improvements for multikey injection and extraction.

before:

-----------------------------------------------------------------------------
Benchmark                                      Time           CPU Iterations
-----------------------------------------------------------------------------
BM_SpanContextMultikeyInjection             1165 ns       1165 ns     601641
BM_SpanContextMultikeyExtraction            1056 ns       1056 ns     657310

after:

-----------------------------------------------------------------------------
Benchmark                                      Time           CPU Iterations
-----------------------------------------------------------------------------
BM_SpanContextMultikeyInjection               76 ns         76 ns    9649126
BM_SpanContextMultikeyExtraction             288 ns        288 ns    2431295

rnburn added 30 commits August 21, 2018 23:04
@rnburn
Tweak span.
82e92da
@rnburn
Use protobuf operation name.
fa7edf4
@rnburn
Avoid storing start_timestamp_.
b5df35e
@rnburn
Don't use embedded span context.
33f0b65
@rnburn
Replace LightStepSpanContext with LightStepImmutableSpanContext.
858220c
@rnburn
s/LightStepSpanContextBase/LightStepSpanContext
a218b39
@rnburn
Remove unused propagation code.
258ad1f
@rnburn
Set tags directly on protobuf object.
ef9a257
@rnburn
Add reference benchmark.
37b7056
@rnburn
Set reference directly on protobuf object.
1119b6a
@rnburn
Set logs on protobuf object.
003eab5
@rnburn
Fix clang-tidy warning.
532478e
@rnburn
Change include order.
f6d54f7
@rnburn
Clear reference before setting.
22cf1a1
@rnburn
Use final specifier.
83a5501
@rnburn
Uncomment tests.
fbc87e1
@rnburn
Merge branch 'master' of github.com:lightstep/lightstep-tracer-cpp in…
325fe4b 
…to memory2
@rnburn
Add benchmark for multikey injection.
4ae88ed
@rnburn
Add span context extraction benchmark.
8477732
@rnburn
Run clang-format.
6928726
@rnburn
Merge branch 'master' of github.com:lightstep/lightstep-tracer-cpp in…
1baac0d 
…to propagation-perf
@rnburn
Add benhmark for empty span context extraction.
5602822
@rnburn
Fix TextMapReader.
1992347
@rnburn
Rewrite Uint64ToHex function.
7be7c68
@rnburn
Improve extraction performance.
87b6bb7
@rnburn
Merge branch 'master' of github.com:lightstep/lightstep-tracer-cpp in…
944207e 
…to fastprop
@rnburn
s/ToUint64/HexToUint64/
ddc5ff0
@rnburn
Add documentation.
3f7b8ec
@rnburn
Clang-tidy fixes.
e7f34d0
@rnburn
Fix comment.
b98e7c5
@rnburn rnburn requested a review from jmacd September 5, 2018 18:43
jmacd
jmacd approved these changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rnburn rnburn merged commit 32bee7b into lightstep:master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnburn @jmacd