Output new tokens to new directory. Output new and legacy namespaces #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for lightspeed-flame ready! Built with commit 81b19e0 |
Closed
glambert
reviewed
Dec 10, 2019
|
Also, do we need to add/update docs for the usage of these tokens? |
glambert
approved these changes
Dec 11, 2019
glambert
requested changes
Dec 11, 2019
| @@ -57,41 +57,45 @@ Note that this command will be run automatically when we publish to npm. | |||
| ### Import SCSS variables | |||
|
|
|||
| ```scss | |||
| @import '@lightspeed/flame-tokens/index.scss'; | |||
| @import '@lightspeed/flame-tokens/sass/index.scss'; | |||
There was a problem hiding this comment.
Isn't this supposed to be @import '@lightspeed/flame-tokens/sass/flame/index.scss'; based on your changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generated CSS/Sass tokens/utilities was starting to get out of sync.
I've quickly updated the generation scripts to output the new values.
I've also taken the time to namespace the newly generated files.
So...
before:
@lightspeed/flame-tokens/partials/index.scssnow:
@lightspeed/flame-tokens/sass/${THEME_NAME_HERE}/partials/index.scssHow to test?
yarn devChecklist