Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chromatic workflow #112

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Add chromatic workflow #112

merged 1 commit into from
Jun 29, 2020

Conversation

xdrdak
Copy link
Contributor

@xdrdak xdrdak commented Jun 29, 2020

Description

Slight adjustment to Alert story to trigger a snapshot.

Made it so that the snapshots are only ran when you target master branch.

How to test?

  • Checkout branch, run yarn dev
  • Open Storybook
  • Or check the deploy preview on Netlify (link available in comments)

Checklist

@xdrdak xdrdak requested a review from a team as a code owner June 29, 2020 15:28
@netlify
Copy link

netlify bot commented Jun 29, 2020

Deploy preview for lightspeed-flame ready!

Built with commit cdbe325

https://deploy-preview-112--lightspeed-flame.netlify.app

@xdrdak xdrdak merged commit d296d6d into next Jun 29, 2020
@xdrdak xdrdak deleted the chromatic-on-flame branch June 29, 2020 17:23
xdrdak added a commit that referenced this pull request Jul 6, 2020
xdrdak added a commit that referenced this pull request Jul 17, 2020
* Add AlertInCard component. Auto color for Alert icons. (#82)

* Add AlertInCard component. Auto color for Alert icons.

* Update Alert/readme.md

* Update CHANGELOG.md

* Remove useless generic in getTheme

* tiny fixes to match design specs

* Update typing ignores

* design feedback. remove useless typing

* hush now codecov

* Force add DSD specific icons if prop not filled

* PR feedback

Co-authored-by: maartenafink <[email protected]>

* [Security] Bump websocket-extensions from 0.1.3 to 0.1.4 (#89)

Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. **This update includes a security fix.**
- [Release notes](https://github.com/faye/websocket-extensions-node/releases)
- [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md)
- [Commits](faye/websocket-extensions-node@0.1.3...0.1.4)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* ForwardRef on Remaining Base Components (#75)

* Forward ref on remaining base components

* adjust changelog

Co-authored-by: Guillaume Lambert <[email protected]>

* Toaster component (#86)

* Add toaster component WIP

* Update jest and testing-library. Tests for toaster

* Update toaster readme

* remove dangling TODO from toaster

* Add better responsiveness for Toaster

* Restrict Toaster types. Bypass click events for ToasterContainer

* Update changelog. Add notice that we are using an external lib

* Remove unused typing file

* Spread rest on Toaster component to auto-pause timer

* Update toaster behaviour to match specs

* Supress warnings for logs. Fix toaster example setup

* less jarring height transition

* fixing text alignment

* Set minHeight for container at 60px

* Test out Percy with animations

Co-authored-by: maartenafink <[email protected]>
Co-authored-by: Guillaume Lambert <[email protected]>

* Move storybook down to package level. Update to 5.3 (#92)

* port over previous tokens stories. Adapt for flame

* Move dependencies to relevant package

* disable css modules as its not really relevant anymore

* update popover and tooltip story styling. sort top level sections

* skip theme percy snapshots as per old implementation

* Remove dead deps. Bubble ExampleBox from popover and tooltip

* Move stories/ into flame/.storybook. Cleanup useless test

* Fix percy command

* Fix weird regression due to injecting components in style tags

* Display themeGet and css for colours instead of classnames

* Fix spaced group

* Colours -> Colors

* remove superflous react devDep

* leverage top level packages

Co-authored-by: Guillaume Lambert <[email protected]>

* cleanup of top level storybook. Fix typing (#98)

* Allow next to be published

* Fix tests for alert. Move publish config to flame

* Flush superfluous version due to merge

* Fix typing issue in Dialog/Story

* [Security] Bump acorn from 6.4.0 to 6.4.1 (#97)

Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1. **This update includes security fixes.**
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@6.4.0...6.4.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Xavier Drdak <[email protected]>

* Publish

 - @lightspeed/[email protected]

* adjust publish scripts (#100)

* Dummy changes to trigger release

* Publish

 - @lightspeed/[email protected]

* Adjust line-height in Alert to be normal. (#101)

* Adjust lineheight in Alert to be normal.

* Update changelog

* Adjust changelog to better sync up with release of RC

* Publish

 - @lightspeed/[email protected]

* Fix code generation typing issue in build-themes

* Publish

 - @lightspeed/[email protected]

* Fix Alert and AlertInCard typing. Allow empty title (#102)

* Fix Alert and AlertInCard typing. Allow empty title

* Update changelog

* Publish

 - @lightspeed/[email protected]

* Use react popper hooks (#104)

* Leverage react-popper usePopper hook

* remove old popper dependency

* update changelog

* fix lint

* Publish

 - @lightspeed/[email protected]

* Force Update active poppers. Fix clickOutside handler (#105)

* add forceUpdate to Dropdown and Popover

* Replace forceUpdate with update. Fix clickOutside hook

* Update CHANGELOG.md

* Set higher zIndex for ToasterContainer (#107)

* set higher zIndex for ToasterContainer

* Update CHANGELOG.md

* Publish

 - @lightspeed/[email protected]

* Add next/Badge component (#106)

* add next/Badge component

* fix colors for oldskool theme

* Update CHANGELOG.md

* Let percy snapshot next

* Use variant prop instead of type for badge

* Update CHANGELOG.md

* Adjust padding based on design feedback

* Fix storybook publishing

Co-authored-by: Guillaume Lambert <[email protected]>

* Publish

 - @lightspeed/[email protected]

* Smoothed out border-radius for next/Badge (#108)

* Smoothed out border-radius for next/Badge

* Update CHANGELOG.md

* Export typing for next/Badge (#110)

* export typing for next/Badge

* Update CHANGELOG.md

* Create (S)CSS-flavored Flame implementation package (#109)

* Port sass as is into flame

* Apply suggestions from code review

Co-authored-by: Guillaume Lambert <[email protected]>

* Update css README docs. Remove media queries css as this is out of scope

* Remove private flag from flame-css

Co-authored-by: Guillaume Lambert <[email protected]>

* Publish

 - @lightspeed/[email protected]
 - @lightspeed/[email protected]

* Move Storybook back to root again (#111)

* move everything back to root

* strip magic from storybook-components. Adjust root package scripts

* Mute typings for withReadme

* Fix netlify build path

* Fix storybook decorator injection condition

* Add chromatic workflow (#112)

* Remove percy. Adjust old percy stuff for chromatic (#114)

* Adjust chromatic workflow

* Use tags as target for publish action. Snapshot label for visual diffing (#115)

* Target tags for action. Snapshot on label

* Pushes on master will trigger a snapshot

* Add "type=text" to input for convenience (#117)

* Publish

 - @lightspeed/[email protected]
 - @lightspeed/[email protected]

* Adjust publishing scripts. Dummy changes to trigger publish

* Publish

 - @lightspeed/[email protected]

Co-authored-by: maartenafink <[email protected]>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Guillaume Lambert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant