Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source account comparison to ClawbackClaimableBalanceOperation, LiquidityPoolWithdrawOperation, and LiquidityPoolDepositOperation for equality check. #484

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Add source account comparison to ClawbackClaimableBalanceOperation, LiquidityPoolWithdrawOperation, and LiquidityPoolDepositOperation for equality check. #484

merged 1 commit into from
Jul 21, 2023

Conversation

overcat
Copy link
Member

@overcat overcat commented Jul 20, 2023

fix #483

@overcat overcat marked this pull request as draft July 20, 2023 06:39
@overcat
Add source account comparison to ClawbackClaimableBalanceOperation,…
89d989b 
… `LiquidityPoolWithdrawOperation`, and `LiquidityPoolDepositOperation` for equality check.
@overcat overcat marked this pull request as ready for review July 20, 2023 07:48
@overcat
Copy link
Member Author

overcat commented Jul 20, 2023

Hi, @sreuland and @tamirms, the PR is ready, could you please review and merge it?

Shaptic
Shaptic approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to assume that all other operations do this source account check?

@overcat
Copy link
Member Author

overcat commented Jul 20, 2023

Is it safe to assume that all other operations do this source account check?

Yes.

@tamirms tamirms merged commit c258f0d into lightsail-network:master Jul 21, 2023
@overcat overcat deleted the fix-equals branch August 11, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaptic Shaptic Shaptic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some operations' __equals__ does not include comparison with the source.
3 participants
@overcat @Shaptic @tamirms