Implement FeeBumpTransaction builder, update SEP10 and SEP29 #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekn
approved these changes
May 4, 2020
Comment on lines
86
to
88
| } catch (IOException exception) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
This code was copied but we probably shouldn't silence errors like this.
|
|
||
| long innerBaseFee = this.mInner.getFee(); | ||
| long numOperations = this.mInner.getOperations().length; | ||
| if (numOperations > 0 ) { |
There was a problem hiding this comment.
Suggested change
| if (numOperations > 0 ) { | |
| if (numOperations > 0) { |
| public FeeBumpTransaction build() { | ||
| if (mBaseFee == null) { | ||
| throw new RuntimeException("base fee has to be set. you must call setBaseFee()."); | ||
| } |
There was a problem hiding this comment.
Nit: can be a one-liner using checkNotNull.
| * account which requires a memo. | ||
| * @throws IOException | ||
| */ | ||
| public SubmitTransactionResponse submitTransaction(FeeBumpTransaction transaction, boolean skipMemoRequiredCheck) throws IOException, AccountRequiresMemoException { |
There was a problem hiding this comment.
Why not merge this and above into one:
public SubmitTransactionResponse submitTransaction(AbstractTransaction transaction, boolean skipMemoRequiredCheck) throws IOException, AccountRequiresMemoException👍 either way.
🤦 I was looking at |
abuiles
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should address all remaining protocol 13 issues in the Java SDK
close #277