[#257] Fixed failures on decoding ASCII text memos #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
reviewed
Dec 5, 2019
tamirms
reviewed
Dec 5, 2019
Gzernov
force-pushed
the
ascii-memo-fix
branch
from
cb16349
to
67e4a89
Compare
|
I'm closing the PR as it's fixed in #259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fixes for issue #257 only to JSON transaction deserializer, which is now get length as minimum of UTF8 and ASCII (under assumption that data from the network is correct)
All other places use old code, which was left untouched.