Adapt to Protocol v11 #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta from the right position
overcat
commented
May 2, 2019
| /** | ||
| * Represents <a href="https://www.stellar.org/developers/learn/concepts/list-of-operations.html#create-passive-offer" target="_blank">CreatePassiveOffer</a> operation. | ||
| * @see <a href="https://www.stellar.org/developers/learn/concepts/list-of-operations.html" target="_blank">List of Operations</a> | ||
| * @deprecated Use {@link CreatePassiveSellOfferOperation} |
There was a problem hiding this comment.
Should I deprecate a class like this?
There was a problem hiding this comment.
We should deprecate this class but it needs to work until removed. We are still pre 1.0.0 version so we can remove it in the next minor version (assuming these changes will be part of 0.7.0, then deprecated methods can be removed in 0.8.0).
There was a problem hiding this comment.
I've added them back, but some behavior may change due to the XDR changes.
overcat
commented
May 2, 2019
overcat
commented
May 2, 2019
|
I am very new in Java world, if you have any suggestions, feel free to let me know. |
|
This is amazing @overcat! @nullstyle can you prioritize reviewing this? |
bartekn
reviewed
May 13, 2019
… partial forward compatibility. ManageOfferOperation actually generates MANAGE_SELL_OFFER, CreatePassiveOfferOperation actually generates CREATE_PASSIVE_SELL_OFFER. BREAKING CHANGE: Looking at the commit description, I recommend using the new class immediately.
overcat
commented
May 14, 2019
overcat
commented
May 14, 2019
bartekn
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #197