Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-colbert-inheritance #34

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

raphaelsty
Copy link
Collaborator

Inherit from Sentence Transformer in order to reduce the amount of code unused in ColBERT models

@raphaelsty raphaelsty force-pushed the sentence-transformer-model-inheritance branch 3 times, most recently from 912d136 to d8eb4cc Compare August 9, 2024 16:19
@raphaelsty raphaelsty force-pushed the sentence-transformer-model-inheritance branch from d8eb4cc to a67528d Compare August 9, 2024 16:21
@raphaelsty raphaelsty self-assigned this Aug 9, 2024
@raphaelsty raphaelsty added the enhancement New feature or request label Aug 9, 2024
@NohTow
Copy link
Collaborator

NohTow commented Aug 12, 2024

Fixed the loading of variables done in the init being overridden by the reading of the variables.
Now it works great and the training seems ok, merging.

@NohTow NohTow merged commit 2e72d68 into main Aug 12, 2024
2 checks passed
@raphaelsty raphaelsty deleted the sentence-transformer-model-inheritance branch August 22, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants