htlcswitch+lnwallet: ReceiveMalformedFailHTLC #7030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostjager
force-pushed
the
receive-malformed
branch
from
9804d54
to
b8df0bf
Compare
joostjager
commented
Oct 13, 2022
| // to an actual error, by encrypting it as if we were | ||
| // the originating hop. | ||
| convertedErrorSize := lnwire.FailureMessageLength + 4 | ||
| if len(pd.FailReason) == convertedErrorSize { |
There was a problem hiding this comment.
Need to think about this deletion in the context of upgrade scenarios with lingering 'old style' malformed fails.
There was a problem hiding this comment.
Migrating Fail to MalformedFail for the pending updates in the channel db doesn't look very attractive.
This was referenced Oct 13, 2022
joostjager
force-pushed
the
receive-malformed
branch
from
b8df0bf
to
299732e
Compare
|
In #6913 (comment), we decided to simply not allow failure messages shorter than 256 bytes. Closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviving a three year old idea described in #3027 (comment).
Variable failure length messages force us to rethink the previously chosen solution that depends on a fixed length, see #6913