Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chainrpc: clarify documentation #6481

Merged

Conversation

torkelrogstad
Copy link
Contributor

@torkelrogstad torkelrogstad commented Apr 30, 2022

Closes #6443.

Change Description

Clarify the comment on RegisterConfirmationsNtfn. The output script
is in fact mandatory, not optional.

Steps to Test

N/A

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

Clarify the comment on RegisterConfirmationsNtfn. The output script
is in fact mandatory, not optional.
@torkelrogstad torkelrogstad force-pushed the 2022-04-30-chain-notifier branch from 321cb69 to d6db386 Compare April 30, 2022 08:44
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the clarification 🎉

@guggero guggero requested a review from yyforyongyu April 30, 2022 14:00
Copy link
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@guggero guggero merged commit aca2299 into lightningnetwork:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear how to subscribe for TX confirmation without public key script
3 participants