-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
routerrpc+lncli: enable subserver by default and switch over lncli sendpayment #4128
routerrpc+lncli: enable subserver by default and switch over lncli sendpayment #4128
Conversation
04d9b41
to
e6a1172
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick pass
Usage: "a zpay32 encoded payment request to fulfill", | ||
}, | ||
cli.Int64Flag{ | ||
Name: "fee_limit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not blocking, but could be a good time to rename this to fee_limit_sat
to match fee_limit_percent
so they both have units
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in doubt about it. It can be done at any time really too. This parameter already existed.
Todo: switch over integration tests to |
56ee174
to
325452c
Compare
Itests switched over. Revealed one bug where routerrpc wasn't setting the payment request, see |
4b61836
to
fe5d73a
Compare
fe5d73a
to
9a181c8
Compare
f965f6b
to
814735b
Compare
814735b
to
cdf9be5
Compare
Moved itest conversion into separate PR #4132 |
With multi-part payments, a payment-level route field does not make sense anymore.
There is an alternative in routerrpc now. It doesn't support REST yet, but the main rpc SendPayment with its bidirectional streaming isn't usable via REST either. SendPaymentSync still serves REST users and cannot be deprecated yet.
cdf9be5
to
3191b94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR removes the conditional compilation logic from
routerrpc
. It will be enabled by default. This is not a big change, as it was already enabled in our pre-built binary releases.With
routerrpc
being available always,lncli
can be switched over to using theSendPayment
call on the sub-server.The old main rpc
SendPayment
andSendPaymentSync
calls are marked as deprecated and expected to be removed in the next major release 0.11.Note: SendToRoute will be switched over too, but after #3970 lands.