Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lncli: allow unlock with password from stdin #4066

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Mar 10, 2020

As discussed with @lispmeister, this is needed to unlock lnd in a containerized environment like Kubernetes. Without this fix, additional unlocking software is needed that performs the unlock call through gRPC.

This could perhaps also be an acceptable compromise to what was suggested in #899.

@Roasbeef Roasbeef added this to the 0.10.0 milestone Mar 10, 2020
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛷

Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔑

@cfromknecht cfromknecht merged commit fcecc5c into lightningnetwork:master Mar 11, 2020
@githorray
Copy link
Contributor

Trouble building on Windows. go version go1.14 windows/amd64

cmd\lncli\commands.go:1810:34: cannot use syscall.Stdin (type syscall.Handle) as
 type int in argument to terminal.ReadPassword
Makefile:91: recipe for target 'build' failed
make: *** [build] Error 2

@githorray
Copy link
Contributor

pw, err = terminal.ReadPassword(int(syscall.Stdin))

seems to have fixed it.

@guggero guggero deleted the unlock-stdin branch March 11, 2020 08:00
@guggero
Copy link
Collaborator Author

guggero commented Mar 11, 2020

Thanks for reporting this, @githorray! Fix is up: #4069.

@githorray
Copy link
Contributor

working great! thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants