cnct: remove nursery dependency from success resolver #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Persistence of the generated sweep tx was already removed earlier, so this field serves no purpose anymore.
chokoboko
reviewed
Feb 3, 2020
To avoid complaints of the linter about copying the lock that will be introduced in a next commit.
joostjager
force-pushed
the
success-resolver-remove-nursery
branch
from
76db847
to
8567cfc
Compare
joostjager
changed the title
joostjager
force-pushed
the
success-resolver-remove-nursery
branch
from
8567cfc
to
69027e2
Compare
Roasbeef
added
commitments
joostjager
force-pushed
the
success-resolver-remove-nursery
branch
from
69027e2
to
f59eb8f
Compare
joostjager
force-pushed
the
success-resolver-remove-nursery
branch
from
f59eb8f
to
6f65189
Compare
This commit updates the success resolver to (only) use the sweeper and not rely on utxo nursery anymore. This also gets rid of an unnecessary wait that was always performed in the nursery. In addition to that, the resolver is made stateless. This prevents us from persisting the contract report and makes the implementation more robust in general.
joostjager
force-pushed
the
success-resolver-remove-nursery
branch
from
6f65189
to
0bc598c
Compare
|
Todo: figure out migration path when nursery is already trying to sweep |
|
For migration, it is probably enough to just run Line 100 in 2cd26d7 Other than that, the (new) resolvers are stateless and will pick up any state the resolution process was left in. |
|
Code got outdated because we didn't prioritize this. Closing PR now, because priority is still low. If that changes in the future, it can still be found as a reference on the parent issue #3688. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.