You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What is the reasoning for not accepting a network serialized raw hex tx at that point, as returned by a Transaction Extractor?
I cannot see any technical reason why the finalized PSBT would be needed: the only extra information inside it (compared to the network tx) is potentially the input UTXOs, but even the presence of those is not guaranteed (and if they were there, they have already been seen by lnd in the earlier steps).
Context: Electrum currently does not expose the finalised PSBT to the user; only the network serialized tx. The "Transation Extractor" phase of the PSBT flow happens automatically. This makes the UX significantly simpler.
The text was updated successfully, but these errors were encountered:
It's certainly possible to modify the interface to accept the final fully signed transaction. One thing we wanted to prevent (depending on how the client can interpret a partial PSBT where only the outputs are populated) is having a user create an invalid funding transaction, which possibly locks up their coins without interaction from the counter-party. Ideally the user always executes the verify call to ensure that they aren't at risk of this, with lnd broadcasting the final funding transaction in the end itself (which also lets it rebroadcast since the transaction will be stored in the wallet).
In this commit, we fix a deadlock that can happen if a user attempts to
init then rapidly unlock a wallet right after. In my profiles, it seems
the lnd gets caught up on the bbolt flock, which deadlocks the entire
process. We fix this issue by making the Init/Unlock calls now fully
synchronous. Only a single outstanding request can exist across the
entire wallet unlocker service now.
Fixeslightningnetwork#4330.
Fixeslightningnetwork#3631.
When fixing this, we should also make sure that the funding flow is not aborted for simple encoding or copy/paste errors as described in point 1 of #4400.
Ideally we ask for the same input in a loop until either a non-nil error is received or the user aborts by pressing Ctrl+C.
When trying open a channel using the CLI in psbt mode, at the last step, after the tx has been signed, lnd only accepts a finalized PSBT.
The PSBT at this point is a complete and signed transaction, as returned by an Input Finalizer.
What is the reasoning for not accepting a network serialized raw hex tx at that point, as returned by a Transaction Extractor?
I cannot see any technical reason why the finalized PSBT would be needed: the only extra information inside it (compared to the network tx) is potentially the input UTXOs, but even the presence of those is not guaranteed (and if they were there, they have already been seen by lnd in the earlier steps).
Context: Electrum currently does not expose the finalised PSBT to the user; only the network serialized tx. The "Transation Extractor" phase of the PSBT flow happens automatically. This makes the UX significantly simpler.
The text was updated successfully, but these errors were encountered: