Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapchannel: use taproot overlay chan type for asset chans #975

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

Roasbeef
Copy link
Member

With this change, we'll use explicit negotiation for the new asset chan
specific chan type.

@Roasbeef Roasbeef requested a review from jharveyb June 25, 2024 22:56
@Roasbeef Roasbeef force-pushed the asset-chan-feature-bit branch from 230dab1 to 8d32b02 Compare June 25, 2024 22:59
@dstadulis dstadulis added this to the v0.4 milestone Jun 26, 2024
@dstadulis dstadulis requested a review from gijswijs June 26, 2024 08:28
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending merge of lnd PR.

Copy link
Contributor

@gijswijs gijswijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit does what is says on the tin. No comments, let's go. 🎉

@Roasbeef Roasbeef force-pushed the asset-chan-feature-bit branch 2 times, most recently from 4a13e83 to c54e3ea Compare June 27, 2024 00:34
Roasbeef added 2 commits June 26, 2024 19:44
With this change, we'll use explicit negotiation for the new asset chan
specific chan type.
@Roasbeef Roasbeef force-pushed the asset-chan-feature-bit branch from c54e3ea to 83b2023 Compare June 27, 2024 02:44
@Roasbeef Roasbeef merged commit 1f59068 into main Jun 27, 2024
16 checks passed
@guggero guggero deleted the asset-chan-feature-bit branch June 28, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants