Fix proof storage clobber error for postgres backend #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixes #961 |
guggero
reviewed
Jun 21, 2024
gijswijs
force-pushed
the
postgres-clobber
branch
from
9391534 to
0e292f3
Compare
guggero
force-pushed
the
postgres-clobber
branch
from
0e292f3 to
651af43
Compare
gijswijs
force-pushed
the
postgres-clobber
branch
from
651af43 to
1083cf1
Compare
GeorgeTsagk
approved these changes
Jun 24, 2024
`UpsertAssetProof` gave issues with a postgresql backend. See: #951 By separating the subquery from the upsert, we can error out if we see more than one asset ID (primary key from table assets) being returned from the database. This should return a more meaningful error than the original postgresql error. Database deadlock errors are now retried similar to database serialization errors.
gijswijs
force-pushed
the
postgres-clobber
branch
from
1083cf1 to
84c739d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #951.
An (intermitent) failure popped up when running itest on the postgres backend.
This draft PR tries to solve this error, initially by unifying the behavior of both backends.
Currenlty the status is that this leads to an error later in the process (only for postgres), where the given number of events rhat exist with the given status is of by one.