RFQ enrich incoming accept messages with sent requests #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit stores outgoing requests in the RFQ stream service and retrieves them when handling corresponding quote accept messages. The retrieved request is then set in a field on the quote accept message.
This commit deprecates the asset ID field in the accept message. Instead, it uses the asset ID from the request field within the accept message. This change allows for the removal of the asset ID field from the accept message.
With the request message now included in accept messages, the asset ID field in accept messages is redundant. This commit removes those redundant asset ID fields.
ffranr
force-pushed
the
rfq-match-accept-to-requests
branch
from
60c8ed1 to
d671060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we enrich incoming accept messages with corresponding sent requests. This involves storing outbound requests before sending and matching incoming accept message responses based on the RFQ quote
ID. This matching process is performed in the RFQ stream service, ensuring that other RFQ services only encounter accept messages with fully populated fields, including the new request field.As a result, transporting the asset ID in the accept message is no longer necessary. The asset ID can be found in the request message.
Removing the asset ID field from the accept wire message is important because it is redundant and isn't clear whether it is
out_assetorin_asset. It also does not have a asset group key counterpart.