Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/tapcli: allow proof file or single proof on insert #856

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented Mar 25, 2024

Related to #841.

In order to be able to directly import a proof leaf that was previously exported with tapcli universe leaves directly into the universe, we allow the proof to either be a proof file or a single transition proof.

@guggero guggero requested review from ffranr and jharveyb March 25, 2024 14:08
cmd/tapcli/universe.go Outdated Show resolved Hide resolved
In order to be able to directly import a proof leaf that was previously
exported with `tapcli universe leaves` directly into the universe, we
allow the proof to either be a proof file or a single transition proof.
Copy link
Contributor

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch!

Was going to suggest checked against our max filesize for proofs but it's already part of proof.File.Decode().

@guggero guggero added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit 47e5533 Mar 26, 2024
14 checks passed
@guggero guggero deleted the universe-proof-insert branch March 26, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants