tapgarden: add FundBatch and SealBatch requests #827

jharveyb · 2024-03-11T15:38:09Z

Closes #820

Update the minting state machines to move batch funding into a separate command that can execute before batch finalization. Add a new command to supply group anchor witnesses before batch finalization.

Remaining TODOs:

dstadulis · 2024-03-19T18:40:39Z

Will be pulled out of draft and merged this sprint

jharveyb · 2024-03-20T01:20:24Z

Feature work is done IMO, follow-on work can happen in a separate PR as this one has already ballooned quite a bit.

Remaining tasks are just unit test coverage AFAICT, should add some usage in an itest as well.

guggero

Very nice! This gets us quite far in terms of re-arranging the state machine. Some commits need some love/cleanup, but apart from that the code looks pretty good.
Will need to do a second pass once we have the follow-up PR building on top of this that exposes the RPC methods to interact with the new states.

tapgarden/planter.go

tapgarden/planter_test.go

tapgarden/planter.go

tapgarden/caretaker.go

tapgarden/planter.go

asset/asset.go

tapgarden/planter.go

jharveyb · 2024-03-21T16:07:05Z

One DB change is actually missing from this PR, related to group key handling. We need to also associate a [32]byte with a Seedling, which would later map to a GroupKey.TapscriptRoot. Without that, a user could not later provide a custom tapscript root for a group key, and if they generated witness using such a root they would not verify with the group virtual TXs made during sealBatch.

tapgarden/interface.go

tapgarden/planter.go

tapdb/asset_minting.go

tapgarden/seedling.go

tapdb/asset_minting.go

tapgarden/planter.go

jharveyb · 2024-03-26T17:56:35Z

Updated to address some feedback and update tests to exercise query changes. Also fixed some issues with not accepting externally-set seedling script keys and group internal keys.

Hitting some issues with minting DB tests around using the seedling group tapscript root.

From discussion offline, I think the simplest behavior for FundBatch and SealBatch would be that they can be called exactly once before Finalize. I don't see a clear use case for making those calls multiple times. Its straightforward to detect if a batch is funded or sealed, so it should also be straightforward to return an error here and require the batch to be resubmitted.

guggero

LGTM, pending existing comments and successful CI run.

tapdb/asset_minting.go

tapdb/assets_common.go

asset/asset.go

jharveyb · 2024-04-03T18:06:39Z

Rebased.

Roasbeef

LGTM 🦚

guggero · 2024-04-09T06:55:19Z

Needs another rebase to apply new linter rules, then a couple of fixes for the new rules.

In this commit, we introduce two new functions that allow batch funding before finalization, and supplying custom group witnesses for asset groups being created in a batch.

In this commit, we export a query from the MintingStore that allows a TX to be bound to a batch before finalization. We also write the TX of a batch, if present, when we are first writing a batch.

In this commit, we move batch funding from the caretaker to the planter, where it can occur before batch finalization. We optionally create a new batch during funding, and we fund batches during finalization before starting a caretaker.

In this commit, we stop using the batch ticker in any minter unit tests. This changed some test behavior, as finalizing via the ticker is non-blocking. We update some assertions to read the DB directly instead of querying the planter to maintain similar guarantees as before. Finally, we remove a test section checking for batch cancellation after finalize, which is not possible as finalize is blocking. This only worked before because it used the batch ticker.

In this commit, we add logic to the planter to produce asset group witnesses for all seedlings in a batch associated with an asset group. We also store the asset groups so they can be fetched by the caretaker during batch finalization.

In this commit, we add a unit test that funds a batch before finalize. This test also provides external keys for some seedlings to ensure that these are handled correctly during minting. We also update the planter to reject fund and finalize calls if a batch is already funded.

jharveyb self-assigned this Mar 11, 2024

jharveyb added this to the v0.4 milestone Mar 11, 2024

jharveyb marked this pull request as draft March 11, 2024 15:39

jharveyb force-pushed the mint_early_sprouting branch 2 times, most recently from f1e8f4d to 4760ae4 Compare March 14, 2024 15:22

jharveyb mentioned this pull request Mar 14, 2024

[bug]: Planter cannot reply to requests while caretaker is finalizing a batch #705

Open

jharveyb force-pushed the mint_early_sprouting branch from 5753433 to a116bf4 Compare March 18, 2024 17:20

This was referenced Mar 19, 2024

tapgarden/taprpc: permit providing a tapscript sibling hash for minting calls #343

Closed

tapgarden: batch write boundaries and batch state when transitioning from planter to caretaker #828

Open

jharveyb force-pushed the mint_early_sprouting branch 2 times, most recently from 3cdbe5c to 1ab4428 Compare March 20, 2024 00:51

jharveyb marked this pull request as ready for review March 20, 2024 01:17

jharveyb requested a review from guggero March 20, 2024 01:18

guggero reviewed Mar 20, 2024

View reviewed changes

jharveyb force-pushed the mint_early_sprouting branch 2 times, most recently from 4c02fc5 to 3064415 Compare March 21, 2024 15:04

jharveyb force-pushed the mint_early_sprouting branch 3 times, most recently from 0a6065a to e3a322f Compare March 22, 2024 16:19

Roasbeef requested changes Mar 23, 2024

View reviewed changes

guggero self-requested a review March 25, 2024 16:55

jharveyb force-pushed the mint_early_sprouting branch 2 times, most recently from b341ded to 973ac8b Compare March 26, 2024 17:39

guggero approved these changes Mar 26, 2024

View reviewed changes

tapdb/asset_minting.go Show resolved Hide resolved

tapdb/assets_common.go Show resolved Hide resolved

asset/asset.go Show resolved Hide resolved

asset/asset.go Outdated Show resolved Hide resolved

jharveyb force-pushed the mint_early_sprouting branch 2 times, most recently from 409b9c8 to d234399 Compare March 29, 2024 19:59

jharveyb force-pushed the mint_early_sprouting branch from c2e1cfd to 42b7bde Compare April 3, 2024 18:06

Roasbeef approved these changes Apr 8, 2024

View reviewed changes

Roasbeef added this pull request to the merge queue Apr 8, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2024

jharveyb added 16 commits April 9, 2024 11:44

tapgarden: refactor batch creation and test utils

64f5fc7

tapgarden: add FundBatch and SealBatch requests

514a806

In this commit, we introduce two new functions that allow batch funding before finalization, and supplying custom group witnesses for asset groups being created in a batch.

tapdb: expose binding a TX to a batch

d092e3e

In this commit, we export a query from the MintingStore that allows a TX to be bound to a batch before finalization. We also write the TX of a batch, if present, when we are first writing a batch.

tapdb: add script, group keys to asset seedlings

db48e49

tapdb: update queries to expose seedling keys

b3de0ce

tapgarden: derive seedling keys on adding to batch

2853430

tapdb+tapgarden: update tests to use seedling keys

e63a0f1

multi: remove batch ticker

3b0de4b

asset: split group virtual TX creation and signing

5bc336c

multi: update tests to build group virtual TXs

500f67a

tapdb: support store/fetch of seedling asset group

dabdacb

tapgarden: implement sealBatch

49f7b1c

In this commit, we add logic to the planter to produce asset group witnesses for all seedlings in a batch associated with an asset group. We also store the asset groups so they can be fetched by the caretaker during batch finalization.

tapgarden: move batch sealing earlier to finalize

0920055

jharveyb force-pushed the mint_early_sprouting branch from 42b7bde to 132a2d0 Compare April 9, 2024 16:48

jharveyb enabled auto-merge April 9, 2024 17:02

jharveyb added this pull request to the merge queue Apr 9, 2024

Merged via the queue into main with commit dc8932d Apr 9, 2024
14 checks passed

guggero deleted the mint_early_sprouting branch April 9, 2024 17:19

jharveyb mentioned this pull request Apr 16, 2024

[feature]: custom Group Key API for minting #722

Closed

3 tasks

jharveyb mentioned this pull request Jul 1, 2024

tapgarden: minting batch display for pre-0.3.3 batches #986

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tapgarden: add FundBatch and SealBatch requests #827

tapgarden: add FundBatch and SealBatch requests #827

jharveyb commented Mar 11, 2024 •

edited

Loading

dstadulis commented Mar 19, 2024

jharveyb commented Mar 20, 2024

guggero left a comment

jharveyb commented Mar 21, 2024

jharveyb commented Mar 26, 2024 •

edited

Loading

guggero left a comment

jharveyb commented Apr 3, 2024

Roasbeef left a comment

guggero commented Apr 9, 2024

tapgarden: add FundBatch and SealBatch requests #827

tapgarden: add FundBatch and SealBatch requests #827

Conversation

jharveyb commented Mar 11, 2024 • edited Loading

dstadulis commented Mar 19, 2024

jharveyb commented Mar 20, 2024

guggero left a comment

Choose a reason for hiding this comment

jharveyb commented Mar 21, 2024

jharveyb commented Mar 26, 2024 • edited Loading

guggero left a comment

Choose a reason for hiding this comment

jharveyb commented Apr 3, 2024

Roasbeef left a comment

Choose a reason for hiding this comment

guggero commented Apr 9, 2024

jharveyb commented Mar 11, 2024 •

edited

Loading

jharveyb commented Mar 26, 2024 •

edited

Loading